Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lupl: fix inject subquery prefix #157

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

lu-pl
Copy link
Contributor

@lu-pl lu-pl commented Dec 2, 2024

Fixes #154 .

lu-pl added 2 commits December 2, 2024 12:06
Subquery injections did not remove SPARQL prefixes before injection,
resulting in invalid SPARQL. The change defines a regex for removing
PREFIX definitions and strips the subquery before injection.

Fixes #154.
@lu-pl lu-pl requested a review from kevinstadler December 2, 2024 11:12
Copy link

@kevinstadler kevinstadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixes #155

@kevinstadler kevinstadler merged commit ecd70d7 into main Dec 2, 2024
9 checks passed
"""Remove SPARQL prefixes from a query.

This is needed for subquery injection, because subqueries cannot have prefixes.
Note that this is not generic, all prefixes are simply ut from the subquery
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simply put?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't handle PREFIXes in SPARQL queries
3 participants